Further align with @typescript-eslint/types
This is an awesome start bc39dcb
but sadly there a a few more places that don't match.
A good start would be by having a look at the latest esrap
version (or more specifically this pr), and go through the few ignored type-check warnings.
Here is a list of what's currently not entirely correct according to the sepc:
Type | property is | property should be |
---|---|---|
TSTypeParameter (property name ) | typeof string | typeof Identifier |
TSFunctionType | parameters | params |
TSFunctionType | typeAnnotation.typeAnnotation | typeParameters |
TSMethodSignature | parameters | params |
TSMethodSignature | typeAnnotation | typeParameters |
This is an incomplete list of course. There are also two or there more type errors inside esrap
that might be related to this, or to wrong type expectations in esrap
. I have excluded those cases in the list above.
Note to self: If we do this we cannot remove the old properties, that would be a breaking change by now, so we gotta keep the old ones around until the next major