feat(cli): pnpm config will now be stored in pnpm-workspace.yaml
#718
Pull request
Closes: #521 Closes: #705 Closes: #714
- Note the addition of
yamlpackage (reco by e18e https://e18e.dev/guide/replacement-guides/js-yaml.html) - working with
pnpm-workspace.yamlfrom[email protected](7 months old). If not fallback topackage.jsonconfig like before this PR. - Targeting the "new tests branch" to see a smaller diff. #717 would need to be merged first.
Info
🦋 Changeset detected
Latest commit: 87235e8
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| sv | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
npx https://pkg.pr.new/sveltejs/cli/sv@718
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@718
commit: 87235e8
@hyunbinseo you might want to try npx https://pkg.pr.new/sveltejs/cli/sv@718 and play with pnpm-workspace.
Seems to be working as expected:
pnpm init
Manually pnpm-workspace.yaml with monorepo setup
packages:
- packages/*
onlyBuiltDependencies:
- esbuild
mkdir packages/hello
cd packages/hello
pnpm dlx https://pkg.pr.new/sveltejs/cli/sv@718 create .
┌ Welcome to the Svelte CLI! (v0.9.5)
│
◇ Which template would you like?
│ SvelteKit minimal
│
◇ Add type checking with TypeScript?
│ Yes, using TypeScript syntax
│
◆ Project created
│
◇ What would you like to add to your project? (use arrow keys / space bar)
│ tailwindcss
│
◇ Which plugins would you like to add?
│ none
│
◆ Successfully setup add-ons
│
◇ Which package manager do you want to install dependencies with?
│ pnpm
│
◆ Successfully installed dependencies
│
◇ What's next? ───────────────────────────────╮
│ │
│ 📁 Project steps │
│ │
│ 1: pnpm run dev --open │
│ │
│ To close the dev server, hit Ctrl-C │
│ │
│ Stuck? Visit us at https://svelte.dev/chat │
│ │
├──────────────────────────────────────────────╯
│
└ You're all set!
packages:
- packages/*
- sites/*
onlyBuiltDependencies:
- esbuild
- '@tailwindcss/oxide'Why the heck did this not close the issues? Edit: Oh maybe because of the colon after the magic keyword. Closing manually
No, I guess that it's because it was a PR against another branch, not against main. (I did mention this in the description ^^)
Thanks for the great work! Why are the related issues reopened?
Because this PR was not targeting main for the moment. Will probably be closed soon
fix(tailwindcss): add @tailwindcss/oxide to approve-builds in pnpm
Pro tip: You can prefix GitHub URLs of issues, PRs or discussions with svcl.dev/ to view them on this page! Also try it on a GitHub release ;)