Remote Functions: Query data not cached if it takes no arguments
#14562
Development PR
fixes #14562
Use same function to generate cache keys for remote query data during ssr and hydration so the logic doesn't need to be duplicated. Fixes an issue where cache keys generated during serialization on the server don't match the cache key used to check the cache for serialized data during hydration.
Current behavior is that the when a query has no arguments, data is serialized with a cache key of the form 'XXXXX/queryName', and the client tries to get the data with a cache key of 'XXXXX/queryname/', so it always results in another round trip to the server during hydration because that key doesn't exist.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
- It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- This message body should clearly illustrate what problems it solves.
- Ideally, include a test that fails without this PR but passes with it.
Tests
- Run the tests with
pnpm testand lint the project withpnpm lintandpnpm check
Changesets
- If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.
Edits
- Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
Issue
Describe the bug
Queries that are not cached don't seem to be cached correctly. Current behavior is that the client makes a fetch call to the exposed endpoint during hydration.
Currently my workaround is to make the query take an argument of v.object({}), and just ignore it. This does require me to call the query everywhere with an argument of {}, but that's only a minor annoyance.
Reproduction
Logs
System Info
System:
OS: Linux 6.14 Ubuntu 25.04 25.04 (Plucky Puffin)
CPU: (12) x64 Intel(R) Core(TM) i7-10750H CPU @ 2.60GHz
Memory: 23.19 GB / 30.59 GB
Container: Yes
Shell: 5.9 - /usr/bin/zsh
Binaries:
Node: 24.5.0 - ~/.volta/tools/image/node/24.5.0/bin/node
npm: 11.5.1 - ~/.volta/tools/image/node/24.5.0/bin/npm
pnpm: 10.14.0 - ~/.volta/bin/pnpm
bun: 1.2.2 - ~/.bun/bin/bun
Severity
serious, but I can work around it
Additional Information
No response
Info
I'm not super familiar with the codebase so I haven't found the exact spot yet, but this seems to be caused by the cache key sometimes having a trailing slash and sometimes not.
SVELTEKIT_PAYLOAD.data is { "1ikvu0a/noArgs": "no args" } but on the client it is checking the cache for a cache key of "1ikvu0a/noArgs/"
Pro tip: You can prefix GitHub URLs of issues, PRs or discussions with svcl.dev/ to view them on this page! Also try it on a GitHub release ;)