Svelte

Ensure cache key generated during ssr matches what is generated durin…

#14563

Closing issue

Pull request

Merged
L
lettucebowler
Sep 29, 2025, 9:35 PM

fixes

Use same function to generate cache keys for remote query data during ssr and hydration so the logic doesn't need to be duplicated. Fixes an issue where cache keys generated during serialization on the server don't match the cache key used to check the cache for serialized data during hydration.

Current behavior is that the when a query has no arguments, data is serialized with a cache key of the form 'XXXXX/queryName', and the client tries to get the data with a cache key of 'XXXXX/queryname/', so it always results in another round trip to the server during hydration because that key doesn't exist.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Info

Merged at Sep 30, 2025, 7:54 AM
Merged by dummdidumm
Assignees None
Reviewers None
Labels None
Milestone None

Pro tip: You can prefix GitHub URLs of issues, PRs or discussions with svcl.dev/ to view them on this page! Also try it on a GitHub release ;)