fix: allow async {@const} in more places
#16643
{@const} in more placesClosing issue
Describe the bug
await doesn't work when used in conjunction with @const
Reproduction
Logs
await isn't allowed in non-async function (Note that you need plugins to import files that are not JavaScript)
System Info
Using Svelte compiler version 5.36.12
running Svelte compiler version 5.36.12
Severity
blocking an upgrade
Pull request
Implemented by reusing the async_body function inside Fragment.js. Also removes the ability to reference a {@const ...} of an implicit child inside a boundary pending/failed snippet:
- existing duplication of consts can have unintended side effects, e.g. async consts would unexpectedly called multiple times
- what if a const is the reason for the failure of a boundary, but is then referenced in the failed snippet?
- what if an async const is referenced in a pending snippet? deadlock
- inconsistent with how it behaves for components where this already does not work
Implemented via / only taking effect with the experimental flag so the behavior change only applies there as this is a breaking change strictly speaking. Also added a compiler error for this.
closes #16462
Before submitting the PR, please make sure you do the following
- It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- Prefix your PR title with
feat:,fix:,chore:, ordocs:. - This message body should clearly illustrate what problems it solves.
- Ideally, include a test that fails without this PR but passes with it.
- If this PR changes code within
packages/svelte/src, add a changeset (npx changeset).
Tests and linting
- Run the tests with
pnpm testand lint the project withpnpm lint
Info
🦋 Changeset detected
Latest commit: d41d821
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| svelte | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
pnpm add https://pkg.pr.new/svelte@16643I had the same issue, and this PR fixed it for me.
As in #16571, the value of $effect.pending() is stuck at a non-zero value after the initial promise has been resolved. For subsequent promises inside the boundary the counter works fine. Is this the intended behavior?
See
@philipplentzen can you open an issue for this? thanks
Issue Philipp mentioned is fixed via #16672
Implemented by reusing the `async_body` function inside `Fragment.js`. Also removes the ability to reference a `{@const ...}` of an implicit child inside a boundary pending/failed snippet:
- existing duplication of consts can have unintended side effects, e.g. async consts would unexpectedly called multiple times
- what if a const is the reason for the failure of a boundary, but is then referenced in the failed snippet?
- what if an async const is referenced in a pending snippet? deadlock
- inconsistent with how it behaves for components where this already does not work
Implemented via the experimental flag so the behavior change only applies there as this is a breaking change strictly speaking. Also added a compiler error for this.
closes #16462