chore(DRAFT): use acorn, estree and esrap
#100
acorn, estree and esrapClosing issues
Can we just use single quotes everywhere?
The Drizzle adder creates the drizzle.config.ts below currently:
if (!process.env.DATABASE_URL) throw new Error('DATABASE_URL is not set');
export default defineConfig({
schema: "./src/lib/server/db/schema.ts",
dbCredentials: {
url: process.env.DATABASE_URL
},
verbose: true,
strict: true,
dialect: "sqlite"
});
recast is using babel, which is much less used in the Svelte ecosystem, so folks wouldn't generally be as familiar with it
Pull request
Benefits
- closer to other tools in the
svelteecosystem - Faster bundling (~33% speed improvement locally from 3s to 2s)
- Smaller bundle (not tested, but dropping babel should dramatically decrease the bundle size)
- more consistent formatting
- we are in full control of the printing, as we own
esrap
Downsides
- Potentially to consistent formatting, as it looks like it's completely ignore the user input (tabs vs spaces, etc), but that's probably fixable in
esrap - Custom typing for special typescript types (see packages/ast-tooling/ts-estree.ts) and Rich-Harris/esrap#13 for reasoning and considered alternatives.
Depends on Rich-Harris/esrap#13. Currently published as esrap-typescript-temp for ease of use for testing. Otherwise, this would require using pnpm link locally with the branch mentioned before.
If we want to proceed with this (which i think we should), this needs to be done
- publish
packages/ast-tooling/ts-estree.tsseperately so that it can also be used insideesrap. Later they should probably live insideacorn-typescriptonce we fork it - make
esrapunderstand what aTSModuleDeclarationis and how to print it - update types inside
esrapaccording to the types above. This will probably also require way more types in this new package - merge the pr inside
esrapand publish it - fix todos
- Testing. I have done a few tests here and there and generally the formatting is way more consistent and matches what i would expect.
Info
![changeset-bot[bot]](https://avatars.githubusercontent.com/in/28616?v=4)
⚠️ No Changeset found
Latest commit: 53921b6
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![pkg-pr-new[bot]](https://avatars.githubusercontent.com/in/882742?v=4)
publish packages/ast-tooling/ts-estree.ts seperately so that it can also be used inside esrap. Later they should probably live inside acorn-typescript once we fork it
I think it'd be preferrable to just duplicate it in the short-term than to add a dependency on ast-tooling from esrap. Hopefully that can be short-lived and we can just add it to the acorn-typescript fork like you suggest
update types inside esrap according to the types above. This will probably also require way more types in this new package
That would be nice, but I wouldn't necessarily block on it. It will be a huge cleanup just to get this done and get off of recast, so if there are some things left for followups that would be fine
I think it'd be preferrable to just duplicate it in the short-term than to add a dependency on
ast-toolingfromesrap. Hopefully that can be short-lived and we can just add it to theacorn-typescriptfork like you suggest
I was thinking about a custom package just for those types, but copying over should also work, if we want proceed with this
Closing, as this PR is hopelessly outdated. The esrap TS PR has been merged, but esrap is just not ready enough for handling such stuff, especially regarding tabs vs spaces and single vs double quoutes.