feat: basic svelte templates
#170
svelte templatesClosing issue
Pull request
Closes #168
Notes:
- added a new
kitcondition for all 3 svelte templates that we had before. This was necessary since all the files we had before did not go well with thesveltetemplate - The original template code was taken from their github main: https://github.com/vitejs/vite/tree/main/packages/create-vite/template-svelte-ts (Looks like main has changes that are not published yet)
tbd:
- see why this
vite-env.d.tsis renamed tovite-env.d.ts. Do we even need this file? - inconsistent indentation in newly create files
- fix tests
- ordering and help text of
sveltetemplate (and possibly other templates, to avoid confusion)
Info
![changeset-bot[bot]](https://avatars.githubusercontent.com/in/28616?v=4)
š¦ Changeset detected
Latest commit: 62cfd9f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| sv | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![pkg-pr-new[bot]](https://avatars.githubusercontent.com/in/882742?v=4)
I think the only open question here is the ordering of the templates, i have screenshotted my preferred way above. We might need to improve the hints to make the differences clearer for the user
ā Which template would you like? ā ā SvelteKit minimal (barebones scaffolding for your new app) ā ā SvelteKit demo (showcase app with a word guessing game that works without JavaScript) ā ā Svelte minimal (barebones scaffolding for your new app) ā ā Svelte library (setup with svelte-package to help correctly package your library)
Another thing might be that we should unify the kit and svelte minimal templates. But that could be done later I think.
Yeah, i had in mind that you mentioned this somewhat recently somewhere. I'm happy to close this as, this was a nice experiment to understand what create-svelte is doing and how it works, so this hasn't been a waste of time in any way!
I don't really know what the right answer is. It could make sense, but we need to be careful around how we present it, so should probably take some time post-launch to make sure we're doing it in a way that helps makes things clearer for users. I do worry about giving people an option with no docs and then they don't know what to do with it. I think that adding a docs page to svelte.dev about when and when not to use SvelteKit and how to accomplish different goals with it (SPA, embedded app, etc.) and how to build something with plain Vite is probably the first step