Svelte

chore: fix ecosystem CI

 #13054

Pull request

Merged
T
teemingc Nov 26, 2024, 3:29 AM

This PR is meant to get the ecosystem CI passing for SvelteKit, which overrides Svelte 4 with 5 (and vite-plugin-svelte 3 with 4 in my testing).

Changes are:

  • update typescript version in test apps to match Svelte 5's so that exists in ts lib. This fixes this CI error where the event type can't be found.
  • explicitly use the "undefined" string in tests in place of undefined values use string templates for values so that the text is visible ().
  • use innerText in place of innerHTML for tests when asserting content so that Svelte 5 hydration marker comments <!-- -> are not captured.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Info

Merged at Nov 27, 2024, 3:02 AM
Merged by benmccann
Assignees None
Reviewers benmccann
Labels None
Milestone None
Back to homepage
Open pull request on GitHub

Pro tip: You can prefix GitHub URLs of issues, PRs or discussions with svcl.dev/ to view them on this page! Also try it on a GitHub release ;)