Fix Todo delete button not disabling while waiting for API response
#2172
Pull request
#1564 - currently the todo's in the demo app suffer from a bug where you can click delete on a todo while the first delete is still pending.
This allows multiple delete requests to be sent, HTTP 500 errors to be received (https://github.com/sveltejs/api.svelte.dev/blob/master/src/routes/todos.ts#L46) and the todo to never visually disappear.
Info
![changeset-bot[bot]](https://avatars.githubusercontent.com/in/28616?v=4)
🦋 Changeset detected
Latest commit: 636eb96
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| create-svelte | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@benmccann Thank you for taking the time to open #2100, that's where I found it :) From the description I thought it wouldn't need to be noted in a changelog since it's just the demo app, so I didn't create the changeset.
@ignatiusmb Thanks for the suggestions! I've never used TS so I wasn't sure if an attribute that isn't always present should be in the type definition.
No worries. I don't normally add a changelog for stuff in the /examples directory but this demo app gets created for users when you run npm init svelte@next and I think I can't release a new version of that package with your fix without a changelog
Update packages/create-svelte/templates/default/src/routes/todos/index.svelte
Co-authored-by: Ignatius Bagus <[email protected]>
Pro tip: You can prefix GitHub URLs of issues, PRs or discussions with svcl.dev/ to view them on this page! Also try it on a GitHub release ;)