fix: remove preprocessor-specific attributes
#653
Closing issue
Describe the bug A recent change in svelte5 made attributes on <script> protected. Proprocessors using custom attributes must remove them to avoid warnings
/home/dominikg/develop/sveltejs/vite-plugin-svelte/packages/e2e-tests/svelte-preprocess/src/lib/multifile/MultiFile.svelte
2:19 error Unrecognized attribute — should be one of `generics`, `lang` or `module`. If this exists for a preprocessor, ensure that the preprocessor removes it(script_unknown_attribute) svelte/valid-compile
Logs Please include browser console and server logs around the time this bug occurred.
To Reproduce clone vite-plugin-svelte repo remove disable comment: https://github.com/sveltejs/vite-plugin-svelte/blob/12b7af76dac68b4cf3b60bba269aa927a2528716/packages/e2e-tests/svelte-preprocess/src/lib/multifile/MultiFile.svelte#L2
run pnpm lint
Expected behavior no warning
Information about your project:
latest vite, svelte5-next and svelte-preprocess
Additional context eslint-plugin-svelte currently makes an error out of this warning, which might be too harsh
Pull request
- global for style tags
- src for script/style tags
fixes #652
@dominikg does this fix the v-p-s issue?
Before submitting the PR, please make sure you do the following
- It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
- This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
- Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to run
pnpm lint!)
Tests
- Run the tests with
npm testorpnpm test
Info
- global for style tags - src for script/style tags fixes #652