fix: don't mark selector lists inside :global with multiple items as unused
#15817
:global with multiple items as unusedClosing issue
Describe the bug
Given a component like this
<style>
:global {
a, b {
color: red;
}
}
</style>
the generated css looks like this
/* :global {*/
/* (unused) a, b*/ {
color: red;
}
/*}*/
which is wrong because there's a block without a selector.
Reproduction
Logs
System Info
Severity
annoyance
Pull request
Merged
D
dummdidumm Apr 22, 2025, 9:03 AMRegression from #15762
Fixes #15816
Before submitting the PR, please make sure you do the following
- It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- Prefix your PR title with
feat:,fix:,chore:, ordocs:. - This message body should clearly illustrate what problems it solves.
- Ideally, include a test that fails without this PR but passes with it.
- If this PR changes code within
packages/svelte/src, add a changeset (npx changeset).
Tests and linting
- Run the tests with
pnpm testand lint the project withpnpm lint
Info
Merged at Apr 22, 2025, 10:03 AM
Merged by paoloricciuti
Assignees None
Reviewers None
Labels None
Milestone None
C
changeset-bot[bot] Apr 22, 2025, 9:03 AM🦋 Changeset detected
Latest commit: 5692de7
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| svelte | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
G
github-actions[bot] Apr 22, 2025, 9:04 AMpnpm add https://pkg.pr.new/svelte@15817 W
wiesson Apr 22, 2025, 10:32 AMThank you! I was just about to report the issue ❤️
Pull request open Apr 22, 2025, 9:03 AM
fix: don't mark selector lists inside :global with multiple items as unused
Regression from #15762 Fixes #15816
Pull request merged Apr 22, 2025, 10:03 AM
.changeset/wild-actors-retire.md +5 5 changes
Total
+25 -11