fix: abort and reschedule $effect.pre when necessary
#16335
$effect.pre when necessaryPull request
Follow-up to #16280 (comment) — just a failing test for now so that we don't lose track of it
Before submitting the PR, please make sure you do the following
- It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- Prefix your PR title with
feat:,fix:,chore:, ordocs:. - This message body should clearly illustrate what problems it solves.
- Ideally, include a test that fails without this PR but passes with it.
- If this PR changes code within
packages/svelte/src, add a changeset (npx changeset).
Tests and linting
- Run the tests with
pnpm testand lint the project withpnpm lint
Info
![changeset-bot[bot]](https://avatars.githubusercontent.com/in/28616?v=4)
⚠️ No Changeset found
Latest commit: b4c6a9e
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?v=4)
pnpm add https://pkg.pr.new/svelte@16335
No and no. Please don't do this.
Since you are here...the original pr also caused this
The problem is that since we are rescheduling the counter to prevent infinite loops increase instead of just staying at 0 and run over the 1001 effects, AND the derived being read in the effect for the first time increase the write version.
Not sure what the fix is yet, leaving this out there just in case is obvious to you