fix: correctly transform {@const foo = await ...}
#16463
{@const foo = await ...}Closing issue
Describe the bug
await doesn't work when used in conjunction with @const
Reproduction
Logs
await isn't allowed in non-async function (Note that you need plugins to import files that are not JavaScript)System Info
Using Svelte compiler version 5.36.12
running Svelte compiler version 5.36.12Severity
blocking an upgrade
Pull request
Closes #16462
Before submitting the PR, please make sure you do the following
- It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- Prefix your PR title with
feat:,fix:,chore:, ordocs:. - This message body should clearly illustrate what problems it solves.
- Ideally, include a test that fails without this PR but passes with it.
- If this PR changes code within
packages/svelte/src, add a changeset (npx changeset).
Tests and linting
- Run the tests with
pnpm testand lint the project withpnpm lint
Info
![changeset-bot[bot]](https://avatars.githubusercontent.com/in/28616?v=4)
🦋 Changeset detected
Latest commit: 2e15163
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| svelte | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?v=4)
pnpm add https://pkg.pr.new/svelte@16463
This fix might not be as easy as I originally thought...
AFAIK snippets themselves aren't async; template expressions are turned into arrow functions that return promises, but async deriveds return a promise (which resolves to a source), so we'd have to wrap that in await, which means the snippet would have to be async, which changes a lot of internal stuff...
We could try to do what we do with the component and split the snippet's functionality into two functions, one async and one sync...
Closing in favor of #16542