fix: avoid false-positive infinite loop error
#16611
Pull request
Closed
D
dummdidumm Aug 13, 2025, 7:26 AMChecks each effect's execution count and only advances the overall flush count if an inidivual effect was executed many times, hinting at a loop
The count overall is kept in place because theoretically there could be other infinite loops happening with no user effect in the mix.
Fixes part of #16548
Before submitting the PR, please make sure you do the following
- It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- Prefix your PR title with
feat:,fix:,chore:, ordocs:. - This message body should clearly illustrate what problems it solves.
- Ideally, include a test that fails without this PR but passes with it.
- If this PR changes code within
packages/svelte/src, add a changeset (npx changeset).
Tests and linting
- Run the tests with
pnpm testand lint the project withpnpm lint
Info
Closed at Aug 17, 2025, 12:32 PM
Assignees None
Reviewers None
Labels None
Milestone None
C
changeset-bot[bot] Aug 13, 2025, 7:26 AM🦋 Changeset detected
Latest commit: 6f0e43d
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| svelte | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
G
github-actions[bot] Aug 13, 2025, 7:28 AMpnpm add https://pkg.pr.new/svelte@16611 D
dummdidumm Aug 13, 2025, 12:29 PM#16612 might be the better solution
D
dummdidumm Aug 17, 2025, 12:32 PM#16631 solved this
Pull request opened Aug 13, 2025, 7:26 AM
Checks each effect's execution count and only advances the overall flush count if an inidivual effect was executed many times, hinting at a loop The count overall is kept in place because theoretically there could be other infinite loops happening with no user effect in the mix. Fixes part of #16548
Pull request closed Aug 17, 2025, 12:32 PM
Total -1 +50