fix: Don't destroy boundary contents on error unless the boundary is an error boundary
#16746
Pull request
Right now, if you wrap some content in a svelte:boundary and don't specify a failed snippet or onerror handler, an error inside that boundary will cause its contents to be destroyed. This is confusing behavior, as you could wrap your app in a svelte:boundary with a pending snippet and suddenly the error behavior would differ (as non-wrapped content is not destroyed on an error). This PR adjusts the logic such that when an error is thrown, as it traverses the boundary tree, it only causes the contents of a boundary to be removed if that boundary is an error boundary (i.e. it defines an onerror handler or a failed snippet).
Before submitting the PR, please make sure you do the following
- It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
- Prefix your PR title with
feat:,fix:,chore:, ordocs:. - This message body should clearly illustrate what problems it solves.
- Ideally, include a test that fails without this PR but passes with it.
- If this PR changes code within
packages/svelte/src, add a changeset (npx changeset).
Tests and linting
- Run the tests with
pnpm testand lint the project withpnpm lint
Info
🦋 Changeset detected
Latest commit: cdd556b
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
| Name | Type |
|---|---|
| svelte | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
pnpm add https://pkg.pr.new/svelte@16746