Svelte

fix: each block losing reactivity when items removed while promise pending

#17151

Closing issue

Pull request

Merged
D
dylan1951
Nov 13, 2025, 6:03 AM

Fixes

When items are temporarily removed while async work is pending, the items can be added to skipped_effects but are not deleted later.

This is my first contribution so any feedback is appreciated and I'm happy to fix anything that needs changing.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Info

Merged at Nov 16, 2025, 2:09 AM
Merged by Rich-Harris
Assignees None
Reviewers None
Labels None
Milestone None

Pro tip: You can prefix GitHub URLs of issues, PRs or discussions with svcl.dev/ to view them on this page! Also try it on a GitHub release ;)